From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540AbdF1B3M (ORCPT ); Tue, 27 Jun 2017 21:29:12 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24156 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdF1B3D (ORCPT ); Tue, 27 Jun 2017 21:29:03 -0400 To: Johannes Thumshirn Cc: "Martin K . Petersen" , Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist , wangyijing@huawei.com Subject: Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170614115243.17776-1-jthumshirn@suse.de> Date: Tue, 27 Jun 2017 21:28:50 -0400 In-Reply-To: <20170614115243.17776-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Wed, 14 Jun 2017 13:52:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes, > libsas uses scsi_queue_work() to queue it's internal event > notifications. scsi_queue_work() can return -EINVAL if the work queue > doesn't exist and it does call queue_work() which can return false if > the work is already queued. Applied to 4.13/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering