From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
qla2xxx-upstream@qlogic.com, himanshu.madhani@cavium.com
Subject: Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device
Date: Wed, 24 May 2017 15:11:48 -0400 [thread overview]
Message-ID: <yq1fufuul1n.fsf@oracle.com> (raw)
In-Reply-To: <20170523145047.5020-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Tue, 23 May 2017 16:50:47 +0200")
Johannes,
> When pci_enable_device() or pci_enable_device_mem() fail in
> qla2x00_probe_one() we bail out but do a call to
> pci_disable_device(). This causes the dev_WARN_ON() in
> pci_disable_device() to trigger, as the device wasn't enabled
> previously.
>
> So instead of taking the 'probe_out' error path we can directly return
> *iff* one of the pci_enable_device() calls fails.
>
> Additionally rename the 'probe_out' goto label's name to the more
> descriptive 'disable_device'.
Applied to 4.12/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-24 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 14:50 [PATCH] qla2xxx: don't disable a not previously enabled PCI device Johannes Thumshirn
2017-05-24 2:37 ` Martin K. Petersen
2017-05-24 15:47 ` Bart Van Assche
2017-05-24 17:12 ` Malavali, Giridhar
2017-05-24 19:11 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fufuul1n.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=himanshu.madhani@cavium.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox