From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978126AbdDXWDc (ORCPT ); Mon, 24 Apr 2017 18:03:32 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45548 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S977218AbdDXWDW (ORCPT ); Mon, 24 Apr 2017 18:03:22 -0400 To: Christoph Hellwig Cc: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" , stable@vger.kernel.org, Johannes Berg , Quentin Lambert , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170420175549.3435196-1-arnd@arndb.de> <20170420175549.3435196-2-arnd@arndb.de> <20170423083635.GB30869@infradead.org> Date: Mon, 24 Apr 2017 18:02:42 -0400 In-Reply-To: <20170423083635.GB30869@infradead.org> (Christoph Hellwig's message of "Sun, 23 Apr 2017 01:36:35 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > sparse found a bug that has always been present since the driver was > merged: > > drivers/scsi/pmcraid.c:2353:12: warning: context imbalance in 'pmcraid_reset_reload' - different lock contexts for basic block > > Fix this by using a common unlock goto label, and also reduce the > indentation level in the function. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering