From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753992AbdC3CkQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 22:40:16 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:37672 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753003AbdC3CkO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 22:40:14 -0400
To: Colin King <colin.king@canonical.com>
Cc: John Garry <john.garry@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: add missing break in switch statement
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20170328111222.17303-1-colin.king@canonical.com>
Date: Wed, 29 Mar 2017 22:39:52 -0400
In-Reply-To: <20170328111222.17303-1-colin.king@canonical.com> (Colin King's
        message of "Tue, 28 Mar 2017 12:12:22 +0100")
Message-ID: <yq1fuhv4hdz.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Colin King <colin.king@canonical.com> writes:

Colin,

> It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION
> case got accidentally removed in an earlier commit, as it stands, the
> ts->stat and ts->open_rej_reason are being updated twice for this case
> which looks incorrect.  Fix this by adding in the missing break
> statement.

Applied to 4.12/scsi-queue.

Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering