From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbdAFBvp (ORCPT ); Thu, 5 Jan 2017 20:51:45 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48769 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753392AbdAFBvh (ORCPT ); Thu, 5 Jan 2017 20:51:37 -0500 To: Nicolas Iooss Cc: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Himanshu Madhani Subject: Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning From: "Martin K. Petersen" Organization: Oracle Corporation References: <20161226132310.3204-1-nicolas.iooss_linux@m4x.org> Date: Thu, 05 Jan 2017 20:51:26 -0500 In-Reply-To: <20161226132310.3204-1-nicolas.iooss_linux@m4x.org> (Nicolas Iooss's message of "Mon, 26 Dec 2016 14:23:09 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Nicolas" == Nicolas Iooss writes: Nicolas> qla24xx_enable_msix() calls scnprintf() with a non-literal Nicolas> format string. This makes clang report -Wformat-security Nicolas> warnings when compiling this function: Himanshu: Please review these two patches! -- Martin K. Petersen Oracle Linux Engineering