From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbcFOCHZ (ORCPT ); Tue, 14 Jun 2016 22:07:25 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28703 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbcFOCHY (ORCPT ); Tue, 14 Jun 2016 22:07:24 -0400 To: Olaf Hering Cc: James Bottomley , "K. Y. Srinivasan" , Haiyang Zhang , "Martin K. Petersen" , devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v3] storvsc: use small sg_tablesize on x86 From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160609162553.10290-1-olaf@aepfle.de> <1465493159.2259.14.camel@linux.vnet.ibm.com> <20160609220120.GA28607@aepfle.de> Date: Tue, 14 Jun 2016 22:07:02 -0400 In-Reply-To: <20160609220120.GA28607@aepfle.de> (Olaf Hering's message of "Fri, 10 Jun 2016 00:01:20 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Olaf" == Olaf Hering writes: Olaf> On Thu, Jun 09, James Bottomley wrote: >> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote: >> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, > >> after > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: >> storvsc: Set > the > tablesize based on the information given by the >> host") >> > >> > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> > >> 0x20 >> >> Are you really sure 32 is the correct size? Olaf> Its a size that works, while the current state does not work at Olaf> all. >> I know 32 it what it had before, but the reason for the commit you >> quote was to improve performance ... Olaf> The commit above broke 32bit. Whoever wants to improve performance Olaf> on this dead horse can submit another patch. K.Y.? -- Martin K. Petersen Oracle Linux Engineering