From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Nitin Gupta <ngupta@vflare.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH 3/4] Staging: zram: allow partial page operations
Date: Tue, 14 Jun 2011 12:36:53 -0400 [thread overview]
Message-ID: <yq1fwnc5pzu.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <x49aadk31u1.fsf@segfault.boston.devel.redhat.com> (Jeff Moyer's message of "Tue, 14 Jun 2011 10:49:26 -0400")
>>>>> "Jeff" == Jeff Moyer <jmoyer@redhat.com> writes:
Jeff> I don't think there's any reason the logical block size can't be
Jeff> increased. For zram, so long as you don't care that the minimum
Jeff> I/O size is 64k on these systems (and by you, I mean the users of
Jeff> zram, like file systems, or anything using the block device
Jeff> directly), then it's a fine trade-off to make.
Jeff> Jens, Martin, what do you guys think about bumping the size of the
Jeff> queue_limits.logical_block_size?
When I wrote the code I thought 64K ought to be enough for anybody.
I don't have a problem bumping it as long as people are aware of the
implications bigger blocks have on the filesystems they put on top.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2011-06-14 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:28 [PATCH 1/4] Staging: zram: Remove useless offset calculation in handle_uncompressed_page() Jerome Marchand
2011-06-10 13:28 ` [PATCH 2/4] Staging: zram: Refactor zram_read/write() functions Jerome Marchand
2011-06-10 13:28 ` [PATCH 3/4] Staging: zram: allow partial page operations Jerome Marchand
2011-06-10 13:28 ` [PATCH 4/4] Staging: zram: Replace mutex lock by a R/W semaphore Jerome Marchand
2011-06-10 16:46 ` Nitin Gupta
2011-06-10 16:41 ` [PATCH 3/4] Staging: zram: allow partial page operations Nitin Gupta
2011-06-13 9:42 ` Jerome Marchand
2011-06-14 14:49 ` Jeff Moyer
2011-06-14 16:36 ` Martin K. Petersen [this message]
2011-07-01 9:47 ` Jerome Marchand
2011-07-14 3:19 ` Nitin Gupta
2011-07-14 3:25 ` Nitin Gupta
2011-07-14 3:24 ` [PATCH 2/4] Staging: zram: Refactor zram_read/write() functions Nitin Gupta
2011-06-10 16:38 ` [PATCH 1/4] Staging: zram: Remove useless offset calculation in handle_uncompressed_page() Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fwnc5pzu.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=jmarchan@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox