From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: James Bottomley <James.Bottomley@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window
Date: Tue, 22 Mar 2011 00:27:42 -0400 [thread overview]
Message-ID: <yq1fwqfu6dd.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <AANLkTinvwKzYiy5M=Eoae_ViRQwVBF-TgedKspP0qagE@mail.gmail.com> (Geert Uytterhoeven's message of "Sat, 19 Mar 2011 21:00:50 +0100")
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes:
Geert> drivers/scsi/sd.c: In function ‘sd_prep_fn’:
Geert> drivers/scsi/sd.c:544: warning: ‘ret’ may be used uninitialized
Geert> in this function
Sorry about that.
sd: Fail discard requests when logical block provisioning has been disabled
Ensure that we kill discard requests after logical block provisioning
has been disabled in sysfs.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3be5db5..7ff61d7 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -597,6 +597,7 @@ static int scsi_setup_discard_cmnd(struct scsi_device *sdp, struct request *rq)
break;
default:
+ ret = BLKPREP_KILL;
goto out;
}
next prev parent reply other threads:[~2011-03-22 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 20:10 [GIT PULL] First round of SCSI updates for 2.6.38 merge window James Bottomley
2011-03-17 21:19 ` Nicholas A. Bellinger
2011-03-19 20:00 ` Geert Uytterhoeven
2011-03-22 4:27 ` Martin K. Petersen [this message]
2011-03-22 12:59 ` Jeff Moyer
2011-03-21 12:21 ` [build failure] " Ingo Molnar
2011-03-21 16:33 ` James Bottomley
2011-03-21 17:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fwqfu6dd.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox