From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Achim Leubner <achim_leubner@adaptec.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] scsi: gdth: Only call dma_free_coherent when buf is not NULL in ioc_general
Date: Mon, 25 Mar 2019 22:23:16 -0400 [thread overview]
Message-ID: <yq1h8bqz84r.fsf@oracle.com> (raw)
In-Reply-To: <20190307231839.3330-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Thu, 7 Mar 2019 16:18:39 -0700")
Nathan,
> When building with -Wsometimes-uninitialized, Clang warns:
>
> drivers/scsi/gdth.c:3662:6: warning: variable 'paddr' is used
> uninitialized whenever 'if' condition is false
> [-Wsometimes-uninitialized]
>
> Don't attempt to call dma_free_coherent when buf is NULL (meaning that
> we never called dma_alloc_coherent and initialized paddr), which avoids
> this warning.
Applied to 5.2/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-03-26 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 23:18 [PATCH] scsi: gdth: Only call dma_free_coherent when buf is not NULL in ioc_general Nathan Chancellor
2019-03-08 21:14 ` Nick Desaulniers
2019-03-08 21:31 ` Nathan Chancellor
2019-03-22 14:30 ` Arnd Bergmann
2019-03-22 15:26 ` Nathan Chancellor
2019-03-20 19:12 ` Nathan Chancellor
2019-03-26 2:23 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8bqz84r.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=achim_leubner@adaptec.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox