Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

Finn Thain
2018-10-14T23:13:46Z

On Sun, 14 Oct 2018, Christoph Hellwig wrote:

> > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);
>
> I think lp should always be non-NULL here.
>

It's not clear from Documentation/scsi/scsi_mid_low_api.txt, but I guess
that's true for scanning of targets.

Is it true in general that queuecommand for a device will not occur before
its slave_alloc and not after its slave_destroy invocation?

(I'm thinking of queuecommand via the other command submission paths, like
ioctl.)

--