Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

Christoph Hellwig
2018-10-15T05:52:07Z

On Mon, Oct 15, 2018 at 10:13:37AM +1100, Finn Thain wrote:
> On Sun, 14 Oct 2018, Christoph Hellwig wrote:
>
> > > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun);
> >
> > I think lp should always be non-NULL here.
> >
>
> It's not clear from Documentation/scsi/scsi_mid_low_api.txt, but I guess
> that's true for scanning of targets.
>
> Is it true in general that queuecommand for a device will not occur before
> its slave_alloc and not after its slave_destroy invocation?

Yes.