Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

Christoph Hellwig
2018-10-17T08:09:28Z

On Tue, Oct 16, 2018 at 04:39:07PM +1100, Finn Thain wrote:
>
> Perhaps I've misunderstood your concern here. Is it a problem that
> esp_scsi.ko may or may not export the function, depending on .config?
>
> For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y &&
> !CONFIG_SCSI_ZORRO_ESP && !CONFIG_SCSI_MAC_ESP, then it would export no
> esp_send_pio_cmd() symbol.
>
> A dummy function (mentioned above) might then avoid a link error from
> "modprobe zorro_esp" or "modprobe mac_esp" in this scenario. (The modules
> would load but fail to work properly.)
>
> This seems a bit too contrived so I'll post v3 for you to consider.

Please leave the possibly unused exports as-is.