From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753771AbeEHFWF (ORCPT ); Tue, 8 May 2018 01:22:05 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51222 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeEHFWE (ORCPT ); Tue, 8 May 2018 01:22:04 -0400 To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180424131558.3010-1-luc.vanoostenryck@gmail.com> Date: Tue, 08 May 2018 01:21:56 -0400 In-Reply-To: <20180424131558.3010-1-luc.vanoostenryck@gmail.com> (Luc Van Oostenryck's message of "Tue, 24 Apr 2018 15:15:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8886 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=319 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805080052 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering