From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jinpu.wang@cloud.ionos.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task()
Date: Wed, 26 Oct 2022 22:23:27 -0400 [thread overview]
Message-ID: <yq1ilk6romi.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <1666781764-123090-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Wed, 26 Oct 2022 18:56:04 +0800")
John,
> In commit 0b639decf651 ("scsi: pm8001: Modify task abort handling for
> SATA task"), code was introduced to dereference "task" pointer in
> pm8001_abort_task(). However there was a pre-existing later check for
> "!task", which spooked the kernel test robot.
>
> Function pm8001_abort_task() should never be passed NULL for "task"
> pointer, so remove that check. Also remove the "unlikely" hint, as
> this is not fastpath code.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-10-27 2:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 10:56 [PATCH] scsi: pm8001: Drop !task check in pm8001_abort_task() John Garry
2022-10-26 10:36 ` Jinpu Wang
2022-10-27 0:30 ` Damien Le Moal
2022-10-27 2:23 ` Martin K. Petersen [this message]
2022-11-08 4:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ilk6romi.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox