* Re: [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units
[not found] <1585185003-31156-1-git-send-email-cang@codeaurora.org>
@ 2020-03-26 8:17 ` Stanley Chu
2020-03-27 2:31 ` Martin K. Petersen
1 sibling, 0 replies; 2+ messages in thread
From: Stanley Chu @ 2020-03-26 8:17 UTC (permalink / raw)
To: Can Guo
Cc: asutoshd, nguyenb, hongwus, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Bean Huo,
Bart Van Assche, Venkat Gopalakrishnan, Tomas Winkler, open list
Hi Can,
On Wed, 2020-03-25 at 18:09 -0700, Can Guo wrote:
> Block layer RPM is enabled for the genernal UFS SCSI devices when they are
> probed by their driver. However block layer RPM is not enabled for UFS
> well-known SCSI devices.
>
> As UFS SCSI devices have their corresponding BSG char devices, accessing
> a BSG char device via IOCTL may send requests to its corresponding SCSI
> device through its request queue. If BSG IOCTL sends a request to a
> well-known SCSI device when hba is not runtime active, due to block layer
> RPM is not eanbled for the well-known SCSI devices, hba, which is at the
> top of a scsi device's parent chain, shall not be resumed, then unexpected
> error would happen.
>
> This change enables block layer RPM for the well-known SCSI devices, so
> that block layer can handle RPM for the well-known SCSI devices just like
> for the general SCSI devices.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
Looks good!
Thanks to make RPM for UFS completed!
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units
[not found] <1585185003-31156-1-git-send-email-cang@codeaurora.org>
2020-03-26 8:17 ` [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units Stanley Chu
@ 2020-03-27 2:31 ` Martin K. Petersen
1 sibling, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-03-27 2:31 UTC (permalink / raw)
To: Can Guo
Cc: asutoshd, nguyenb, hongwus, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Stanley Chu, Bean Huo,
Bart Van Assche, Venkat Gopalakrishnan, Tomas Winkler, open list
Can,
> Block layer RPM is enabled for the genernal UFS SCSI devices when they
> are probed by their driver. However block layer RPM is not enabled for
> UFS well-known SCSI devices.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread