* [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message
@ 2024-12-12 22:18 Paul Menzel
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paul Menzel @ 2024-12-12 22:18 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen
Cc: Paul Menzel, MPT-FusionLinux.pdl, linux-scsi, linux-kernel
Linux 5.15 logs the error below
mpt3sas_cm0: overriding NVDATA EEDPTagMode setting
on a Dell PowerEdge T440 with the card below.
5e:00.0 Serial Attached SCSI controller [0107]: Broadcom / LSI SAS3008 PCI-Express Fusion-MPT SAS-3 [1000:0097] (rev 02)
It’s not clear to a user what this error is about. As a first step to
improve this, add the values to the error message.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index ed5046593fda..87fcafce947c 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -5627,7 +5627,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc)
if (rc)
return rc;
if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) {
- pr_err("%s: overriding NVDATA EEDPTagMode setting\n",
+ pr_err("%s: overriding NVDATA EEDPTagMode setting from 0 to 1.\n",
ioc->name);
ioc->manu_pg11.EEDPTagMode &= ~0x3;
ioc->manu_pg11.EEDPTagMode |= 0x1;
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
2024-12-12 22:18 [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Paul Menzel
@ 2024-12-12 22:18 ` Paul Menzel
2024-12-12 22:20 ` Paul Menzel
2025-01-02 18:45 ` Martin K. Petersen
2025-01-02 18:45 ` [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Martin K. Petersen
2025-01-10 21:16 ` Martin K. Petersen
2 siblings, 2 replies; 6+ messages in thread
From: Paul Menzel @ 2024-12-12 22:18 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, James Bottomley,
Nagalakshmi Nandigama
Cc: Paul Menzel, Sreekanth Reddy, MPT-FusionLinux.pdl, linux-scsi,
linux-kernel
Currently, the code does:
if (x == 0) {
x &= ~0x3;
x |= 0x1;
}
Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So
directly set the variable to 1.
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 87fcafce947c..2cd0bb606d88 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -5629,8 +5629,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc)
if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) {
pr_err("%s: overriding NVDATA EEDPTagMode setting from 0 to 1.\n",
ioc->name);
- ioc->manu_pg11.EEDPTagMode &= ~0x3;
- ioc->manu_pg11.EEDPTagMode |= 0x1;
+ ioc->manu_pg11.EEDPTagMode = 0x1;
mpt3sas_config_set_manufacturing_pg11(ioc, &mpi_reply,
&ioc->manu_pg11);
}
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
@ 2024-12-12 22:20 ` Paul Menzel
2025-01-02 18:45 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2024-12-12 22:20 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, James Bottomley
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel
[Remove non-working @lsi.com addresses]
Am 12.12.24 um 23:18 schrieb Paul Menzel:
> Currently, the code does:
>
> if (x == 0) {
> x &= ~0x3;
> x |= 0x1;
> }
>
> Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So
> directly set the variable to 1.
>
> Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
> Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 87fcafce947c..2cd0bb606d88 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -5629,8 +5629,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc)
> if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) {
> pr_err("%s: overriding NVDATA EEDPTagMode setting from 0 to 1.\n",
> ioc->name);
> - ioc->manu_pg11.EEDPTagMode &= ~0x3;
> - ioc->manu_pg11.EEDPTagMode |= 0x1;
> + ioc->manu_pg11.EEDPTagMode = 0x1;
> mpt3sas_config_set_manufacturing_pg11(ioc, &mpi_reply,
> &ioc->manu_pg11);
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
2024-12-12 22:20 ` Paul Menzel
@ 2025-01-02 18:45 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 18:45 UTC (permalink / raw)
To: Paul Menzel
Cc: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, James Bottomley,
Nagalakshmi Nandigama, Sreekanth Reddy, MPT-FusionLinux.pdl,
linux-scsi, linux-kernel
Paul,
> Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So
> directly set the variable to 1.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message
2024-12-12 22:18 [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Paul Menzel
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
@ 2025-01-02 18:45 ` Martin K. Petersen
2025-01-10 21:16 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-02 18:45 UTC (permalink / raw)
To: Paul Menzel
Cc: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Martin K. Petersen, MPT-FusionLinux.pdl,
linux-scsi, linux-kernel
Paul,
> Linux 5.15 logs the error below
>
> mpt3sas_cm0: overriding NVDATA EEDPTagMode setting
>
> on a Dell PowerEdge T440 with the card below.
>
> 5e:00.0 Serial Attached SCSI controller [0107]: Broadcom / LSI SAS3008 PCI-Express Fusion-MPT SAS-3 [1000:0097] (rev 02)
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message
2024-12-12 22:18 [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Paul Menzel
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
2025-01-02 18:45 ` [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Martin K. Petersen
@ 2025-01-10 21:16 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2025-01-10 21:16 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E.J. Bottomley, Paul Menzel
Cc: Martin K . Petersen, MPT-FusionLinux.pdl, linux-scsi,
linux-kernel
On Thu, 12 Dec 2024 23:18:11 +0100, Paul Menzel wrote:
> Linux 5.15 logs the error below
>
> mpt3sas_cm0: overriding NVDATA EEDPTagMode setting
>
> on a Dell PowerEdge T440 with the card below.
>
> 5e:00.0 Serial Attached SCSI controller [0107]: Broadcom / LSI SAS3008 PCI-Express Fusion-MPT SAS-3 [1000:0097] (rev 02)
>
> [...]
Applied to 6.14/scsi-queue, thanks!
[1/2] scsi: mpt3sas: Add details to EEDPTagMode error message
https://git.kernel.org/mkp/scsi/c/09ecc187ebde
[2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
https://git.kernel.org/mkp/scsi/c/ad7c3c0cb8f6
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-10 21:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-12 22:18 [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Paul Menzel
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
2024-12-12 22:20 ` Paul Menzel
2025-01-02 18:45 ` Martin K. Petersen
2025-01-02 18:45 ` [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Martin K. Petersen
2025-01-10 21:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox