* RE: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
2019-12-03 10:07 ` [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS sheebab
@ 2019-12-03 10:31 ` Alim Akhtar
2019-12-04 13:36 ` Vignesh Raghavendra
2019-12-10 0:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Alim Akhtar @ 2019-12-03 10:31 UTC (permalink / raw)
To: 'sheebab', avri.altman, pedrom.sousa, jejb,
martin.petersen, stanley.chu, beanhuo, yuehaibing, linux-scsi,
linux-kernel, vigneshr
Cc: mparab, rafalc
> -----Original Message-----
> From: sheebab <sheebab@cadence.com>
> Sent: 03 December 2019 15:37
> To: alim.akhtar@samsung.com; avri.altman@wdc.com;
> pedrom.sousa@synopsys.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; stanley.chu@mediatek.com;
> beanhuo@micron.com; yuehaibing@huawei.com; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; vigneshr@ti.com
> Cc: mparab@cadence.com; rafalc@cadence.com; sheebab
> <sheebab@cadence.com>
> Subject: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
>
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
trigger is
> happening. After the interrupt issue is sorted out autohibern8 feature
will be re-
> enabled
>
> Signed-off-by: sheebab <sheebab@cadence.com>
> ---
Probably we want to mark this as FIX for the older kernel version?
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c
b/drivers/scsi/ufs/cdns-pltfrm.c index
> b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba
> *hba,
> * completed.
> */
> ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + /*
> + * Disabling Autohibern8 feature in cadence UFS
> + * to mask unexpected interrupt trigger.
> + */
> + hba->ahit = 0;
>
> return 0;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
2019-12-03 10:07 ` [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS sheebab
2019-12-03 10:31 ` Alim Akhtar
@ 2019-12-04 13:36 ` Vignesh Raghavendra
2019-12-10 0:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Vignesh Raghavendra @ 2019-12-04 13:36 UTC (permalink / raw)
To: sheebab, alim.akhtar, avri.altman, pedrom.sousa, jejb,
martin.petersen, stanley.chu, beanhuo, yuehaibing, linux-scsi,
linux-kernel
Cc: mparab, rafalc
On 03/12/19 3:37 pm, sheebab wrote:
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
> trigger is happening. After the interrupt issue is sorted out autohibern8
> feature will be re-enabled
>
> Signed-off-by: sheebab <sheebab@cadence.com>
> ---
Tested-by: Vignesh Raghavendra <vigneshr@ti.com>
You will have to repost patch 2/2[1] of your previous series as that
patch no longer applies cleanly anymore given that we no longer want 1/2
to be merged.
[1]
https://lore.kernel.org/linux-scsi/1574147082-22725-3-git-send-email-sheebab@cadence.com/
> drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
> index b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
> * completed.
> */
> ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + /*
> + * Disabling Autohibern8 feature in cadence UFS
> + * to mask unexpected interrupt trigger.
> + */
> + hba->ahit = 0;
>
> return 0;
> }
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
2019-12-03 10:07 ` [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS sheebab
2019-12-03 10:31 ` Alim Akhtar
2019-12-04 13:36 ` Vignesh Raghavendra
@ 2019-12-10 0:05 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-12-10 0:05 UTC (permalink / raw)
To: sheebab
Cc: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
stanley.chu, beanhuo, yuehaibing, linux-scsi, linux-kernel,
vigneshr, mparab, rafalc
sheebab,
> This patch disables autohibern8 feature in Cadence UFS. The
> autohibern8 feature has issues due to which unexpected interrupt
> trigger is happening. After the interrupt issue is sorted out
> autohibern8 feature will be re-enabled
Applied to 5.5/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread