From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752413AbdKUDP5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 22:15:57 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:37527 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751877AbdKUDP4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 22:15:56 -0500
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Varun Prakash <varun@chelsio.com>, linux-kernel@vger.kernel.org,
        Philippe Ombredanne <pombredanne@nexb.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: csiostor: remove unneeded DRIVER_LICENSE #define
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20171117142122.GF17880@kroah.com>
Date: Mon, 20 Nov 2017 22:15:45 -0500
In-Reply-To: <20171117142122.GF17880@kroah.com> (Greg Kroah-Hartman's message
        of "Fri, 17 Nov 2017 15:21:22 +0100")
Message-ID: <yq1k1ykmie6.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Greg,

> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.

Applied to 4.16/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering