* [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect
@ 2025-10-17 7:55 liuqiangneo
2025-10-17 16:59 ` Karan Tilak Kumar (kartilak)
2025-10-22 0:58 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: liuqiangneo @ 2025-10-17 7:55 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, Qiang Liu
From: Qiang Liu <liuqiang@kylinos.cn>
Remove the self-assignment statement of the intr_time_type variable
Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
---
drivers/scsi/fnic/fnic_res.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_res.c b/drivers/scsi/fnic/fnic_res.c
index 763475587b7f..9801e5fbb0dd 100644
--- a/drivers/scsi/fnic/fnic_res.c
+++ b/drivers/scsi/fnic/fnic_res.c
@@ -134,7 +134,6 @@ int fnic_get_vnic_config(struct fnic *fnic)
c->luns_per_tgt));
c->intr_timer = min_t(u16, VNIC_INTR_TIMER_MAX, c->intr_timer);
- c->intr_timer_type = c->intr_timer_type;
/* for older firmware, GET_CONFIG will not return anything */
if (c->wq_copy_count == 0)
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect
2025-10-17 7:55 [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect liuqiangneo
@ 2025-10-17 16:59 ` Karan Tilak Kumar (kartilak)
2025-10-22 0:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2025-10-17 16:59 UTC (permalink / raw)
To: liuqiangneo@163.com, Satish Kharat (satishkh),
Sesidhar Baddela (sebaddel),
James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiang Liu
On Friday, October 17, 2025 12:55 AM, liuqiangneo@163.com <liuqiangneo@163.com> wrote:
>
>
> Remove the self-assignment statement of the intr_time_type variable
>
> Signed-off-by: Qiang Liu <liuqiang@kylinos.cn>
> ---
> drivers/scsi/fnic/fnic_res.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fnic_res.c b/drivers/scsi/fnic/fnic_res.c
> index 763475587b7f..9801e5fbb0dd 100644
> --- a/drivers/scsi/fnic/fnic_res.c
> +++ b/drivers/scsi/fnic/fnic_res.c
> @@ -134,7 +134,6 @@ int fnic_get_vnic_config(struct fnic *fnic)
> c->luns_per_tgt));
>
> c->intr_timer = min_t(u16, VNIC_INTR_TIMER_MAX, c->intr_timer);
> - c->intr_timer_type = c->intr_timer_type;
>
> /* for older firmware, GET_CONFIG will not return anything */
> if (c->wq_copy_count == 0)
> --
> 2.43.0
>
>
Looks good to me. Thanks for the change.
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect
2025-10-17 7:55 [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect liuqiangneo
2025-10-17 16:59 ` Karan Tilak Kumar (kartilak)
@ 2025-10-22 0:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-10-22 0:58 UTC (permalink / raw)
To: liuqiangneo
Cc: satishkh, sebaddel, kartilak, James.Bottomley, martin.petersen,
linux-scsi, linux-kernel, Qiang Liu
> Remove the self-assignment statement of the intr_time_type variable
Applied to 6.19/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-22 0:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-17 7:55 [PATCH] scsi:fnic: Self-assignment of intr_time_type has no effect liuqiangneo
2025-10-17 16:59 ` Karan Tilak Kumar (kartilak)
2025-10-22 0:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox