From: "Martin K. Petersen" <mkp@kernel.org>
To: HOYOUNG SEO <hy50.seo@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
bvanassche@acm.org, mkp@kernel.org, martin.petersen@oracle.com,
stanleyjhu@google.com, peter.wang@mediatek.com,
alim.akhtar@samsung.com, kwangwon.min@samsung.com,
kwmad.kim@samsung.com, cpgsproxy1@samsung.com,
h10.kim@samsung.com
Subject: Re: [PATCH v10 0/4] scsi: ufs: core: Avoid redundant link recovery from the error handler during PM
Date: Tue, 17 Nov 2026 22:44:10 -0500 [thread overview]
Message-ID: <yq1mrr6st1j.fsf@mail.kernel.org> (raw)
In-Reply-To: <2052256418.81794387787276.JavaMail.epsvc@epcpadp2new>
Hoyoung,
> If a LINERESET is reported and the hibern8 exit fails during system
> resume, both ufshcd_err_handler() and __ufshcd_wl_resume() call
> ufshcd_link_recovery(), and the two recoveries are not serialized.
>
> Patch 1 makes ufshcd_link_recovery() clear the saved errors like
> ufshcd_reset_and_restore() does, so the error handler does not act on
> errors that have already been recovered.
>
> Patches 2 and 3 make ufshcd_wl_poweroff() behave like
> ufshcd_wl_suspend() by sharing its implementation. In particular it now
> holds host_sem, so that the error handler waits for it, and the release
> of host_sem is balanced if hibernation is aborted.
>
> Patch 4 restricts the early link recovery in ufshcd_err_handler(), which
> does not hold host_sem, to runtime PM. For system PM and poweroff the
> error handler now waits for host_sem, and for shutdown it stops.
Applied to 7.5/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-11-18 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261111082303epcas2p180a7cf157dedd181634550630fe78df5@epcas2p1.samsung.com>
2026-11-11 8:18 ` [PATCH v10 0/4] scsi: ufs: core: Avoid redundant link recovery from the error handler during PM HOYOUNG SEO
2026-11-11 11:53 ` Stanley Jhu
2026-11-18 3:44 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mrr6st1j.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bvanassche@acm.org \
--cc=cpgsproxy1@samsung.com \
--cc=h10.kim@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox