From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<jinpu.wang@cloud.ionos.com>, <damien.lemoal@wdc.com>,
<hare@suse.de>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<ipylypiv@google.com>, <changyuanl@google.com>
Subject: Re: [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers
Date: Fri, 21 Oct 2022 23:05:00 -0400 [thread overview]
Message-ID: <yq1mt9owodi.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <1666091763-11023-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Tue, 18 Oct 2022 19:15:56 +0800")
John,
> All other libsas drivers manage the tags internally. Tag management in
> pm8001 and mvsas is currently using a simple bitmap, so use the
> request tag when available there. With this change we still need to
> manage tags for libsas "internal" commands, like SMP commands, and any
> other private commands so reserve some tags for this:
> - For pm8001 I went with pre-existing and unused PM8001_RESERVE_SLOT
> size. The value is 8, which should be enough. It is greater than
> mvsas, below, but this driver sends a lot of other private commands to
> HW.
> - For mvsas I went with 4, which still should be enough.
>
> isci and aic9xx have elaborate tag alloc schemes, so I'm not going to
> bother changing them, especially since I have no HW to test with.
>
> Helper sas_task_find_rq() is added to get the request and associated
> tag per sas_task when it is available.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-10-22 3:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 11:15 [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers John Garry
2022-10-18 11:15 ` [PATCH v4 1/7] scsi: libsas: Add sas_task_find_rq() John Garry
2022-10-18 11:15 ` [PATCH v4 2/7] scsi: hisi_sas: Use sas_task_find_rq() John Garry
2022-10-18 11:15 ` [PATCH v4 3/7] scsi: hisi_sas: Put reserved tags in lower region of tagset John Garry
2022-10-18 12:02 ` Hannes Reinecke
2022-10-18 11:16 ` [PATCH v4 4/7] scsi: pm8001: Remove pm8001_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 5/7] scsi: pm8001: Use sas_task_find_rq() for tagging John Garry
2022-10-18 12:03 ` Hannes Reinecke
2022-10-18 11:16 ` [PATCH v4 6/7] scsi: mvsas: Delete mvs_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 7/7] scsi: mvsas: Use sas_task_find_rq() for tagging John Garry
2022-10-22 3:05 ` Martin K. Petersen [this message]
2022-10-27 2:58 ` [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mt9owodi.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=changyuanl@google.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox