From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported
Date: Tue, 18 Jun 2019 23:35:16 -0400 [thread overview]
Message-ID: <yq1muieuu17.fsf@oracle.com> (raw)
In-Reply-To: <20190612020828.8140-1-marcos.souza.org@gmail.com> (Marcos Paulo de Souza's message of "Tue, 11 Jun 2019 23:08:28 -0300")
Marcos,
> WWID composed from VPD data from device, specifically page 0x83. So,
> when a device does not have VPD support, for example USB storage
> devices where VPD is specifically disabled, a read into <blk
> device>/device/wwid file will always return ENXIO. To avoid this,
> change the scsi_sdev_attr_is_visible function to hide wwid sysfs file
> when the devices does not support VPD.
Not a big fan of attribute files that come and go.
Why not just return an empty string? Hannes?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-19 3:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 2:08 [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported Marcos Paulo de Souza
2019-06-18 22:47 ` Marcos Paulo de Souza
2019-06-19 3:35 ` Martin K. Petersen [this message]
2019-06-19 6:34 ` Hannes Reinecke
2019-06-19 9:52 ` Marcos Paulo de Souza
2019-06-19 9:57 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1muieuu17.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox