From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754098AbdEIB4Z (ORCPT <rfc822;w@1wt.eu>);
        Mon, 8 May 2017 21:56:25 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:16994 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752232AbdEIB4Y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2017 21:56:24 -0400
To: Christoph Hellwig <hch@infradead.org>
Cc: Thierry Escande <thierry.escande@collabora.com>,
        Bart Van Assche <Bart.VanAssche@sandisk.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com>
        <20170505090201.GA31209@infradead.org>
Date: Mon, 08 May 2017 21:55:41 -0400
In-Reply-To: <20170505090201.GA31209@infradead.org> (Christoph Hellwig's
        message of "Fri, 5 May 2017 02:02:01 -0700")
Message-ID: <yq1mvamssiq.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Christoph,

> Normally we'd just pass the scsi_sense_hdr structure in from the caler
> if we care about sense data.  Is this something you considered?
>
> Otherwise this looks fine to me.

I agree with Christoph that passing the sense header would be more
consistent with the rest of the SCSI code. Even if we only need the key
in this case.

-- 
Martin K. Petersen	Oracle Linux Engineering