From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Gregor Radtke <mail@g-radtke.name>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, Tim Kunschke <beatmeistah@web.de>
Subject: [PATCH] pata_cs5536 Fix secondary port configuration
Date: Tue, 12 Feb 2008 09:37:25 -0500 [thread overview]
Message-ID: <yq1myq6p7fe.fsf_-_@sermon.lab.mkp.net> (raw)
In-Reply-To: <1202662829.6418.8.camel@desktop.ein-elch.local> (Gregor Radtke's message of "Sun\, 10 Feb 2008 18\:00\:29 +0100")
>>>>> "Gregor" == Gregor Radtke <mail@g-radtke.name> writes:
>> Try booting your pata_cs5536 kernel with libata.dma=0
Gregor> hmm.. boots perfectly, of course somewhat slow. dmesg output:
Brown paper bag time. My devel board has a 16MB 1st generation
compact flash on the secondary so I never noticed this was hosed.
Please try the following patch...
--
Martin K. Petersen Oracle Linux Engineering
Fix speed negotiation for slave device.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff -r 9f5ca67cc28f drivers/ata/pata_cs5536.c
--- a/drivers/ata/pata_cs5536.c Mon Feb 11 20:52:01 2008 -0800
+++ b/drivers/ata/pata_cs5536.c Tue Feb 12 08:52:43 2008 -0500
@@ -40,7 +40,7 @@
#include <asm/msr.h>
#define DRV_NAME "pata_cs5536"
-#define DRV_VERSION "0.0.6"
+#define DRV_VERSION "0.0.7"
enum {
CFG = 0,
@@ -153,8 +153,8 @@ static void cs5536_set_piomode(struct at
struct ata_device *pair = ata_dev_pair(adev);
int mode = adev->pio_mode - XFER_PIO_0;
int cmdmode = mode;
- int dshift = ap->port_no ? IDE_D1_SHIFT : IDE_D0_SHIFT;
- int cshift = ap->port_no ? IDE_CAST_D1_SHIFT : IDE_CAST_D0_SHIFT;
+ int dshift = adev->devno ? IDE_D1_SHIFT : IDE_D0_SHIFT;
+ int cshift = adev->devno ? IDE_CAST_D1_SHIFT : IDE_CAST_D0_SHIFT;
u32 dtc, cast, etc;
if (pair)
@@ -201,7 +201,7 @@ static void cs5536_set_dmamode(struct at
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
u32 dtc, etc;
int mode = adev->dma_mode;
- int dshift = ap->port_no ? IDE_D1_SHIFT : IDE_D0_SHIFT;
+ int dshift = adev->devno ? IDE_D1_SHIFT : IDE_D0_SHIFT;
if (mode >= XFER_UDMA_0) {
cs5536_read(pdev, ETC, &etc);
next prev parent reply other threads:[~2008-02-12 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 21:00 pata_cs5536 hangs on boot with hdd attached Gregor Radtke
2008-02-05 6:16 ` Martin K. Petersen
2008-02-10 17:00 ` Gregor Radtke
2008-02-12 14:37 ` Martin K. Petersen [this message]
2008-02-12 23:17 ` [PATCH] pata_cs5536 Fix secondary port configuration Gregor Radtke
2008-02-13 7:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1myq6p7fe.fsf_-_@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=beatmeistah@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@g-radtke.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox