* [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static
@ 2019-04-17 15:05 Yue Haibing
2019-04-18 15:50 ` James Smart
2019-04-19 0:37 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-17 15:05 UTC (permalink / raw)
To: james.smart, dick.kennedy, jejb, martin.petersen
Cc: linux-kernel, linux-scsi, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 8e0de48..eaaef68 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
* is destroyed.
*
**/
-void
+static void
lpfc_sli4_oas_verify(struct lpfc_hba *phba)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static
2019-04-17 15:05 [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static Yue Haibing
@ 2019-04-18 15:50 ` James Smart
2019-04-19 0:37 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2019-04-18 15:50 UTC (permalink / raw)
To: Yue Haibing, dick.kennedy, jejb, martin.petersen; +Cc: linux-kernel, linux-scsi
On 4/17/2019 8:05 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
> symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 8e0de48..eaaef68 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
> * is destroyed.
> *
> **/
> -void
> +static void
> lpfc_sli4_oas_verify(struct lpfc_hba *phba)
> {
>
Looks good. Interesting as there's a prototype for the function earlier
which defines it as static.
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static
2019-04-17 15:05 [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static Yue Haibing
2019-04-18 15:50 ` James Smart
@ 2019-04-19 0:37 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-04-19 0:37 UTC (permalink / raw)
To: Yue Haibing
Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-kernel,
linux-scsi
Yue,
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
> symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
Applied to 5.2/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-19 0:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-17 15:05 [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static Yue Haibing
2019-04-18 15:50 ` James Smart
2019-04-19 0:37 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox