From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbeEOCdi (ORCPT ); Mon, 14 May 2018 22:33:38 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:42804 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbeEOCdg (ORCPT ); Mon, 14 May 2018 22:33:36 -0400 To: Kees Cook Cc: "Martin K. Petersen" , Boaz Harrosh , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libosd: Remove VLA usage From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180502225545.GA45533@beast> Date: Mon, 14 May 2018 22:33:27 -0400 In-Reply-To: <20180502225545.GA45533@beast> (Kees Cook's message of "Wed, 2 May 2018 15:55:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8893 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=581 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805150023 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, > On the quest to remove all VLAs from the kernel[1] this rearranges the > code to avoid a VLA warning under -Wvla (gcc doesn't recognize "const" > variables as not triggering VLA creation). Additionally cleans up variable > naming to avoid 80 character column limit. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering