From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Adam Radford <aradford@gmail.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: 3w-9xxx: rework lock timeouts
Date: Mon, 20 Nov 2017 22:07:58 -0500 [thread overview]
Message-ID: <yq1o9nwmir5.fsf@oracle.com> (raw)
In-Reply-To: <20171110155840.1941250-3-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 10 Nov 2017 16:58:27 +0100")
Arnd,
> The TW_IOCTL_GET_LOCK ioctl uses do_gettimeofday() to check whether a
> lock has expired. This can misbehave due to a concurrent
> settimeofday() call, as it is based on 'real' time, and it will
> overflow in y2038 on 32-bit architectures, producing unexpected
> results when used across the overflow time.
>
> This changes it to using monotonic time, using ktime_get() to simplify
> the code.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-11-21 3:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 15:58 [PATCH 1/3] scsi: 3ware: fix 32-bit time calculations Arnd Bergmann
2017-11-10 15:58 ` [PATCH 2/3] scsi: 3ware: use 64-bit times for FW time sync Arnd Bergmann
2017-11-10 19:43 ` adam radford
2017-11-21 3:06 ` Martin K. Petersen
2017-11-10 15:58 ` [PATCH 3/3] scsi: 3w-9xxx: rework lock timeouts Arnd Bergmann
2017-11-10 19:36 ` adam radford
2017-11-21 3:07 ` Martin K. Petersen [this message]
2017-11-10 19:42 ` [PATCH 1/3] scsi: 3ware: fix 32-bit time calculations adam radford
2017-11-21 3:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o9nwmir5.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aradford@gmail.com \
--cc=arnd@arndb.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox