[PATCH] scsi: advansys: disallow ISA-only build

[PATCH] scsi: advansys: disallow ISA-only build

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The ISA support for this driver was removed a while ago,
but the Kconfig dependencies still need an update to require
EISA or PCI.

Fixes: 9b4c8eaa68d0 ("advansys: remove ISA support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 03e71e3d5e5b..5956d2bfc9d9 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -462,8 +462,7 @@ config SCSI_MVUMI
 config SCSI_ADVANSYS
 	tristate "AdvanSys SCSI support"
 	depends on SCSI
-	depends on ISA || EISA || PCI
-	depends on ISA_DMA_API || !ISA
+	depends on EISA || PCI
 	help
 	  This is a driver for all SCSI host adapters manufactured by
 	  AdvanSys. It is documented in the kernel source in
-- 
2.39.2

Re: [PATCH] scsi: advansys: disallow ISA-only build

[Martin K. Petersen]

Arnd,

> The ISA support for this driver was removed a while ago, but the
> Kconfig dependencies still need an update to require EISA or PCI.

Applied to 6.4/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: advansys: disallow ISA-only build

[Arnd Bergmann]

On Thu, Apr 20, 2023, at 14:40, Pascal Hambourg wrote:
> Hello Arnd, Peter,
>
> Arnd Bergmann wrote:
>> The ISA support for this driver was removed a while ago,
>> but the Kconfig dependencies still need an update to require
>> EISA or PCI.
>
> A month ago I posted to linux-scsi about the module failing to to init 
> if ISA support is disabled in the kernel config (copy attached), but 
> have not received any answer so far. Any thoughts ?
> Attachments:
> * [Bug report] scsi: advansys: module init fails if ISA_BUS_API is not set.eml
[https://lore.kernel.org/all/5b30b2b2-c47a-da1e-8106-025c914faebd@plouf.fr.eu.org]

Thanks for getting back to me on that. It looks like my patch
was incorrect after all, and only the ISA_DMA_API should have
been removed, as it's now impossible to build a VLB-only version
of the driver.

I think the two ways we can address this are:

- your approach c), which makes it behave the same as the aha1542.c and
  g_NCR5380.c drivers, plus a Kconfig fix to add back ISA_BUS_API
  as a possible alternative to PCI and EISA (thus fixing my patch).

- your approach d), removing VLB support for this driver. I tried to
  find other VLB drivers and the only ones I see remaining in linux-6.3
  are drivers/ata/pata_legacy and drivers/net/ethernet/amd/pcnet32.c.
  Bartlomiej Zolnierkiewicz (added to Cc) is the only one that I can
  see having actually touched VLB drivers at all in over a decade, he
  might know more.

      Arnd