From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] scsi: aacraid: Fix missing break in switch statement
Date: Wed, 27 Feb 2019 09:33:47 -0500 [thread overview]
Message-ID: <yq1pnrd9u7o.fsf@oracle.com> (raw)
In-Reply-To: <20190215214242.GA8393@embeddedor> (Gustavo A. R. Silva's message of "Fri, 15 Feb 2019 15:42:42 -0600")
Gustavo,
> Add missing break statement and fix identation issue.
So much bad indentation in this driver. Tried various tab widths and it
is still all over the place.
Anyway. After staring at the firmware header I have convinced myself
that your fix is correct. Applied to 5.1/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-02-27 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 21:42 [PATCH] scsi: aacraid: Fix missing break in switch statement Gustavo A. R. Silva
2019-02-27 14:33 ` Martin K. Petersen [this message]
2019-02-27 20:07 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pnrd9u7o.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=aacraid@microsemi.com \
--cc=gustavo@embeddedor.com \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox