From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbeERQGS (ORCPT ); Fri, 18 May 2018 12:06:18 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:38912 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbeERQGO (ORCPT ); Fri, 18 May 2018 12:06:14 -0400 To: Kees Cook Cc: "Martin K. Petersen" , Adaptec OEM Raid Solutions , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, LKML Subject: Re: [PATCH] scsi: dpt_i2o: Remove VLA usage From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180502222138.GA22088@beast> Date: Fri, 18 May 2018 12:06:02 -0400 In-Reply-To: (Kees Cook's message of "Fri, 18 May 2018 08:12:29 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8897 signatures=668699 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=717 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805180175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, >> On the quest to remove all VLAs from the kernel[1] this moves the sg_list >> variable off the stack, as already done for other allocated buffers in >> adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). > > Friendly ping! How does this look for v4.18? Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering