The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Len Bao <len.bao@gmx.us>
Cc: Nilesh Javali <njavali@marvell.com>,
	Manish Rangankar <mrangankar@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs_emit()
Date: Tue, 19 Aug 2025 22:08:31 -0400	[thread overview]
Message-ID: <yq1qzx6wy9r.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250811170639.65597-1-len.bao@gmx.us> (Len Bao's message of "Mon, 11 Aug 2025 17:06:32 +0000")


Hi Len!

> Documentation/filesystems/sysfs.rst mentions that show() should only
> use sysfs_emit()

It's a "should", not a "shall".

sysfs.rst was recently amended to emphasize that this suggestion applies
to new implementations only.  See commit 2115dc3e3376 ("docs:
filesystems: sysfs: Recommend sysfs_emit() for new code only").

Thanks!

-- 
Martin K. Petersen

  reply	other threads:[~2025-08-20  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 17:06 [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs_emit() Len Bao
2025-08-20  2:08 ` Martin K. Petersen [this message]
2025-08-23  8:14   ` Len Bao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1qzx6wy9r.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=len.bao@gmx.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mrangankar@marvell.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox