* [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static
@ 2018-01-11 16:55 Colin King
2018-01-17 6:02 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-01-11 16:55 UTC (permalink / raw)
To: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E . J . Bottomley, Martin K . Petersen, MPT-FusionLinux.pdl,
linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function _get_st_from_smid is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol '_get_st_from_smid' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index a44b9be6e3c5..13d6e4ec3022 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -888,7 +888,7 @@ _base_async_event(struct MPT3SAS_ADAPTER *ioc, u8 msix_index, u32 reply)
return 1;
}
-struct scsiio_tracker *
+static struct scsiio_tracker *
_get_st_from_smid(struct MPT3SAS_ADAPTER *ioc, u16 smid)
{
struct scsi_cmnd *cmd;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static
2018-01-11 16:55 [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static Colin King
@ 2018-01-17 6:02 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-01-17 6:02 UTC (permalink / raw)
To: Colin King
Cc: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
James E . J . Bottomley, Martin K . Petersen, MPT-FusionLinux.pdl,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> The function _get_st_from_smid is local to the source and does
> not need to be in global scope, so make it static.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-17 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 16:55 [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static Colin King
2018-01-17 6:02 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox