From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbeAQGCo (ORCPT + 1 other); Wed, 17 Jan 2018 01:02:44 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:35718 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbeAQGCl (ORCPT ); Wed, 17 Jan 2018 01:02:41 -0500 To: Colin King Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E . J . Bottomley" , "Martin K . Petersen" , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180111165539.1248-1-colin.king@canonical.com> Date: Wed, 17 Jan 2018 01:02:33 -0500 In-Reply-To: <20180111165539.1248-1-colin.king@canonical.com> (Colin King's message of "Thu, 11 Jan 2018 16:55:39 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8776 signatures=668653 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=598 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801170086 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Colin, > The function _get_st_from_smid is local to the source and does > not need to be in global scope, so make it static. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering