public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bean Huo <beanhuo@iokpp.de>
Cc: avri.altman@sandisk.com, bvanassche@acm.org,
	alim.akhtar@samsung.com, jejb@linux.ibm.com,
	martin.petersen@oracle.com, can.guo@oss.qualcomm.com,
	beanhuo@micron.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m
Date: Mon, 01 Dec 2025 12:25:26 -0500	[thread overview]
Message-ID: <yq1seduunc2.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251130151508.3076994-1-beanhuo@iokpp.de> (Bean Huo's message of "Sun, 30 Nov 2025 16:15:08 +0100")


Hi Bean!

> When CONFIG_SCSI_UFSHCD=y and CONFIG_RPMB=m, the kernel fails to link
> with undefined references to ufs_rpmb_probe() and ufs_rpmb_remove():
>
>   ld: drivers/ufs/core/ufshcd.c:8950: undefined reference to `ufs_rpmb_probe'
>   ld: drivers/ufs/core/ufshcd.c:10505: undefined reference to `ufs_rpmb_remove'
>
> The issue occurs because IS_ENABLED(CONFIG_RPMB) evaluates to true
> when CONFIG_RPMB=m, causing the header to declare the real function
> prototypes.

This now breaks the modular build for me.

-- 
Martin K. Petersen

  reply	other threads:[~2025-12-01 17:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-30 15:15 [PATCH] scsi: ufs: core: Fix link error when CONFIG_RPMB=m Bean Huo
2025-12-01 17:25 ` Martin K. Petersen [this message]
2025-12-01 22:42   ` Bean Huo
2025-12-02  0:53     ` Bart Van Assche
2025-12-02  9:12       ` Bean Huo
2025-12-02 11:41         ` Jens Wiklander
2025-12-02 12:17           ` Bean Huo
2025-12-02 13:17             ` Jens Wiklander
2025-12-02 13:25               ` Arnd Bergmann
2025-12-02 14:59                 ` Bean Huo
2025-12-02 15:47                   ` Arnd Bergmann
2025-12-02 15:57                     ` Bean Huo
2025-12-02 14:17               ` Bean Huo
2025-12-03  6:15 ` kernel test robot
2025-12-03 14:39   ` Arnd Bergmann
2025-12-03 16:23     ` Bean Huo
2025-12-03 20:31       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1seduunc2.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@sandisk.com \
    --cc=beanhuo@iokpp.de \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox