* [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr
@ 2024-02-15 15:35 Colin Ian King
2024-02-15 20:14 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-15 15:35 UTC (permalink / raw)
To: Michael Reed, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
The variable mr being assigned a value that is never read, the assignment
is redundant and can be removed.
Cleans up clang scan build warning:
drivers/scsi/qla1280.c:2481:2: warning: Value stored to 'mr' is never
read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/qla1280.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 27bce80262c2..8958547ac111 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -2478,7 +2478,6 @@ qla1280_mailbox_command(struct scsi_qla_host *ha, uint8_t mr, uint16_t *mb)
/* Load return mailbox registers. */
optr = mb;
iptr = (uint16_t *) &ha->mailbox_out[0];
- mr = MAILBOX_REGISTER_COUNT;
memcpy(optr, iptr, MAILBOX_REGISTER_COUNT * sizeof(uint16_t));
if (ha->flags.reset_marker)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr
2024-02-15 15:35 [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr Colin Ian King
@ 2024-02-15 20:14 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2024-02-15 20:14 UTC (permalink / raw)
To: Colin Ian King
Cc: Michael Reed, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> The variable mr being assigned a value that is never read, the assignment
> is redundant and can be removed.
Applied to 6.9/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-15 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-15 15:35 [PATCH][next] scsi: qla1280: remove redundant assignment to variable mr Colin Ian King
2024-02-15 20:14 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox