From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbdJaMZd (ORCPT ); Tue, 31 Oct 2017 08:25:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41251 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbdJaMZb (ORCPT ); Tue, 31 Oct 2017 08:25:31 -0400 To: Cathy Avery Cc: Christoph Hellwig , Tejun Heo , kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, dan.carpenter@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun From: "Martin K. Petersen" Organization: Oracle Corporation References: <1508261721-24144-1-git-send-email-cavery@redhat.com> <20171019153510.GA7633@infradead.org> <20171021154444.GK1302522@devbig577.frc2.facebook.com> Date: Tue, 31 Oct 2017 08:24:44 -0400 In-Reply-To: <20171021154444.GK1302522@devbig577.frc2.facebook.com> (Tejun Heo's message of "Sat, 21 Oct 2017 08:44:44 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> If you use alloc_ordered_workqueue directly instead of >> create_singlethread_workqueue you can pass a format string and don't >> need the separate allocation. >> >> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. > > The only thing that flag does is exempting the workqueue from possible > flush deadlock check as we don't know whether WQ_MEM_RECLAIM on a > legacy workqueue is intentional. There's no reason to add it when > converting to alloc_ordered_workqueue(). Just decide whether it needs > forward progress guarantee and use WQ_MEM_RECLAIM if so. Cathy? -- Martin K. Petersen Oracle Linux Engineering