From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751118AbdBAC6W (ORCPT ); Tue, 31 Jan 2017 21:58:22 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:16446 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbdBAC6U (ORCPT ); Tue, 31 Jan 2017 21:58:20 -0500 To: Christoph Hellwig Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: remove the cmd_type field from struct request From: "Martin K. Petersen" Organization: Oracle References: <1485878251-6107-1-git-send-email-hch@lst.de> Date: Tue, 31 Jan 2017 21:58:09 -0500 In-Reply-To: <1485878251-6107-1-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Tue, 31 Jan 2017 16:57:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Christoph" == Christoph Hellwig writes: Christoph> this series gets rid of the cmd_type field in struct Christoph> request and instead folds it into the REQ_OP* space. This Christoph> reduces the size of struct request, and leads to a single op Christoph> namespace that drivers can easily switch on. Very nice cleanup! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering