* [RESEND PATCH] scsi: qla4xxx: Add missing is_qla4022 check in device initialization
@ 2025-05-10 9:52 Wentao Liang
2025-05-21 2:08 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2025-05-10 9:52 UTC (permalink / raw)
To: njavali, James.Bottomley, martin.petersen
Cc: mrangankar, GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel,
Wentao Liang
The current code only checks for is_qla4032 in the adapter initialization
logic, but is_qla4022 is also required for proper handling of qla4022
devices. This can lead to incorrect behavior on qla4022 adapters.
This patch adds the missing is_qla4022 check to ensure proper handling
of both qla4022 and qla4032 devices during adapter initialization.
Fixes: d915058f4874 ("[SCSI] qla4xxx: add support for qla4032")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/scsi/qla4xxx/ql4_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 301bc09c8365..dfe3d0b26224 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
@@ -513,7 +513,7 @@ static int qla4xxx_fw_ready(struct scsi_qla_host *ha)
"seconds expired= %d\n", ha->host_no, __func__,
ha->firmware_state, ha->addl_fw_state,
timeout_count));
- if (is_qla4032(ha) &&
+ if ((is_qla4022(ha) || is_qla4032(ha)) &&
!(ha->addl_fw_state & FW_ADDSTATE_LINK_UP) &&
(timeout_count < ADAPTER_INIT_TOV - 5)) {
break;
--
2.42.0.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] scsi: qla4xxx: Add missing is_qla4022 check in device initialization
2025-05-10 9:52 [RESEND PATCH] scsi: qla4xxx: Add missing is_qla4022 check in device initialization Wentao Liang
@ 2025-05-21 2:08 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2025-05-21 2:08 UTC (permalink / raw)
To: Nilesh Javali
Cc: Wentao Liang, James.Bottomley, martin.petersen, mrangankar,
GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel
> The current code only checks for is_qla4032 in the adapter
> initialization logic, but is_qla4022 is also required for proper
> handling of qla4022 devices. This can lead to incorrect behavior on
> qla4022 adapters.
>
> This patch adds the missing is_qla4022 check to ensure proper handling
> of both qla4022 and qla4032 devices during adapter initialization.
Nilesh: Please review, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-21 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-10 9:52 [RESEND PATCH] scsi: qla4xxx: Add missing is_qla4022 check in device initialization Wentao Liang
2025-05-21 2:08 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox