From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbdF1Brq (ORCPT ); Tue, 27 Jun 2017 21:47:46 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18442 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbdF1Brh (ORCPT ); Tue, 27 Jun 2017 21:47:37 -0400 To: Johan Hovold Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH RESEND] scsi: sun_esp: fix device reference leaks From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170621093509.GL6366@localhost> Date: Tue, 27 Jun 2017 21:47:27 -0400 In-Reply-To: <20170621093509.GL6366@localhost> (Johan Hovold's message of "Wed, 21 Jun 2017 11:35:09 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan, > Make sure to drop the reference to the dma device taken by > of_find_device_by_node() on probe errors and on driver unbind. Looks good to me. Applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering