From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1161720AbdDUPha (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Apr 2017 11:37:30 -0400
Received: from aserp1050.oracle.com ([141.146.126.70]:50253 "EHLO
        aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1161360AbdDUPhS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Apr 2017 11:37:18 -0400
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
        Christoph Hellwig <hch@lst.de>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
        Hannes Reinecke <hare@suse.de>,
        James Bottomley <jejb@linux.vnet.ibm.com>,
        Jinpu Wang <jinpu.wang@profitbricks.com>,
        John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20170421121141.20701-1-jthumshirn@suse.de>
Date: Fri, 21 Apr 2017 10:37:22 -0400
In-Reply-To: <20170421121141.20701-1-jthumshirn@suse.de> (Johannes Thumshirn's
        message of "Fri, 21 Apr 2017 14:11:41 +0200")
Message-ID: <yq1tw5hltct.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: aserp1040.oracle.com [141.146.126.69]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Johannes,

> Move scsi_remove_host call into sas_remove_host and remove it from SAS
> HBA drivers, so we don't mess up the ordering. This solves an issue
> with double deleting sysfs entries that was introduced by the change
> of sysfs behaviour from commit bcdde7e ("sysfs: make
> __sysfs_remove_dir() recursive").

Yeah, I prefer this approach.

Applied to 4.12/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering