From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Adam Radford <aradford@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Michael Reed <mdr@sgi.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] scsi: qla1280: Fix a function name in comments
Date: Tue, 28 Sep 2021 23:12:43 -0400 [thread overview]
Message-ID: <yq1v92kf5pj.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210925125324.1760-1-caihuoqing@baidu.com> (Cai Huoqing's message of "Sat, 25 Sep 2021 20:53:21 +0800")
Cai,
> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.
pci_map_single() was the appropriate interface when the change log entry
was written. And the original entry accurately describes the change that
was made to the code back then. Whereas your proposed fix does not.
There is little benefit to having change logs in drivers in a modern
context. However, these entries predate git history and should therefore
be preserved.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-29 3:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 12:53 [PATCH 1/3] scsi: qla1280: Fix a function name in comments Cai Huoqing
2021-09-25 12:53 ` [PATCH 2/3] scsi: 3w-xxxx: " Cai Huoqing
2021-09-29 3:13 ` Martin K. Petersen
2021-09-25 12:53 ` [PATCH 3/3] scsi: lpfc: " Cai Huoqing
2021-09-29 3:15 ` Martin K. Petersen
2021-09-29 3:12 ` Martin K. Petersen [this message]
2021-10-05 4:34 ` [PATCH 1/3] scsi: qla1280: " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v92kf5pj.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=aradford@gmail.com \
--cc=caihuoqing@baidu.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox