From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF4CC4363A for ; Mon, 26 Oct 2020 20:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D72F2085B for ; Mon, 26 Oct 2020 20:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="kLpEm4VA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbgJZU5t (ORCPT ); Mon, 26 Oct 2020 16:57:49 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:59018 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728557AbgJZU5s (ORCPT ); Mon, 26 Oct 2020 16:57:48 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09QKsTmn102446; Mon, 26 Oct 2020 20:57:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=gNEIQOIVcRf/UxQtEMIApb6sRiQ4CW4rFIAipHvLmnA=; b=kLpEm4VAk5YCSraOYQRGv2tsONAb+CJVVrdP4aOYleng97336wlfA2c7Vaz1rT5N8BvN fp+mwepci/3GDpyzZvGpnfRyalRJxXWogaub51gFC43eCWPKSek/WDtxCt46Q0tbJrbu 4FZbtY0Fp1dzU1qn43A7L0lgzO+PW+p2/qKO7nBdD85TkvTpp84aLxhQDJnJuW/iW+KE 103y8CHyWe8FwZFGot6rdrD+eGtVJiNjC+IRraEnJNwuLFwKubJdsmYgpXFNy5lKRyaq JbJtS8u1jFHxJoiypSLeyBhpNOFmq++l9XHGoSJ3xeAviYv8JVqeP+TFDgFb8WP+dvYN 2g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 34dgm3vd50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 26 Oct 2020 20:57:40 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09QKtwYM140084; Mon, 26 Oct 2020 20:57:39 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 34cx5wc9t4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Oct 2020 20:57:39 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09QKvZds028632; Mon, 26 Oct 2020 20:57:37 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Oct 2020 13:57:34 -0700 To: Helge Deller Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, James Bottomley Subject: Re: [PATCH] scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201022090005.GA9000@ls3530.fritz.box> Date: Mon, 26 Oct 2020 16:57:31 -0400 In-Reply-To: <20201022090005.GA9000@ls3530.fritz.box> (Helge Deller's message of "Thu, 22 Oct 2020 11:00:05 +0200") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9786 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=974 suspectscore=1 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010260136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9786 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=1 clxscore=1011 mlxscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010260136 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Helge, > The mptscsih_remove() function triggers a kernel oops if the > Scsi_Host pointer (ioc->sh) is NULL, as can be seen in this syslog: Applied to 5.10/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering