* [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry()
@ 2020-04-21 3:41 Jason Yan
2020-04-22 17:34 ` Khalid Aziz
2020-04-24 17:30 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-21 3:41 UTC (permalink / raw)
To: khalid, jejb, martin.petersen, colin.king, linux-scsi,
linux-kernel
Cc: Jason Yan
The '!=' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:
drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
needed here
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/BusLogic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index b5b3154e2c28..bb49d83cadc7 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -2237,7 +2237,7 @@ static bool __init blogic_inquiry(struct blogic_adapter *adapter)
"INQUIRE INSTALLED DEVICES ID 0 TO 7");
for (tgt_id = 0; tgt_id < 8; tgt_id++)
adapter->tgt_flags[tgt_id].tgt_exists =
- (installed_devs0to7[tgt_id] != 0 ? true : false);
+ installed_devs0to7[tgt_id] != 0;
}
/*
Issue the Inquire Setup Information command.
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry()
2020-04-21 3:41 [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry() Jason Yan
@ 2020-04-22 17:34 ` Khalid Aziz
2020-04-24 17:30 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Khalid Aziz @ 2020-04-22 17:34 UTC (permalink / raw)
To: Jason Yan, jejb, martin.petersen, colin.king, linux-scsi,
linux-kernel
On 4/20/20 9:41 PM, Jason Yan wrote:
> The '!=' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
> needed here
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/BusLogic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index b5b3154e2c28..bb49d83cadc7 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2237,7 +2237,7 @@ static bool __init blogic_inquiry(struct blogic_adapter *adapter)
> "INQUIRE INSTALLED DEVICES ID 0 TO 7");
> for (tgt_id = 0; tgt_id < 8; tgt_id++)
> adapter->tgt_flags[tgt_id].tgt_exists =
> - (installed_devs0to7[tgt_id] != 0 ? true : false);
> + installed_devs0to7[tgt_id] != 0;
> }
> /*
> Issue the Inquire Setup Information command.
>
Acked-by: Khalid Aziz <khalid@gonehiking.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry()
2020-04-21 3:41 [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry() Jason Yan
2020-04-22 17:34 ` Khalid Aziz
@ 2020-04-24 17:30 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-04-24 17:30 UTC (permalink / raw)
To: Jason Yan
Cc: khalid, jejb, martin.petersen, colin.king, linux-scsi,
linux-kernel
Jason,
> The '!=' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/scsi/BusLogic.c:2240:46-51: WARNING: conversion to bool not
> needed here
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-24 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-21 3:41 [PATCH] scsi: BusLogic: remove conversion to bool in blogic_inquiry() Jason Yan
2020-04-22 17:34 ` Khalid Aziz
2020-04-24 17:30 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox