From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 969CCC04AA7 for ; Mon, 13 May 2019 22:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67BAE208C2 for ; Mon, 13 May 2019 22:44:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EQttmGn/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726533AbfEMWoX (ORCPT ); Mon, 13 May 2019 18:44:23 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:56352 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfEMWoX (ORCPT ); Mon, 13 May 2019 18:44:23 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4DMeIET025302; Mon, 13 May 2019 22:44:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=J0SaY0C/2+hxtSRGUntOmxjyOBtThYkRZq8wG7on/d8=; b=EQttmGn/A0aO3QzWtMyw9Phw4dEjuFlKedS1Iscils7Rh5X9uw3rH6+81SUfyQwy3KEA ztqLQCz5tkTCJyOCyLIkM+zkEyYmH5EL7U+/jnppWfYkWGRzG1G11gnJWwMSWPBP22oT ql+e81ixTvFk1YEL3mXEPx53/cK+tISaorHyqoDpjJCnqCZ1VhtYpTl4P9ryLvMQRAWf JnOwItxgfERFeRflCfs9Edci3mmFgK40NmYMbKHA2p4U9vX8DegtLyd+AIQLbruU47VH JA227i//QGmzNqKxp9T2ovBpVfBstPdehElCAXcunTDdzO/wZa8elQV7k54vpaGISeZP nA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2sdq1qa2p1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 May 2019 22:44:15 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4DMgFTh029745; Mon, 13 May 2019 22:42:15 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2sf3cmx3an-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 May 2019 22:42:15 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4DMgEEj022234; Mon, 13 May 2019 22:42:14 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 May 2019 15:42:13 -0700 To: YueHaibing Cc: , , , , Subject: Re: [PATCH] scsi: myrs: Fix uninitialized variable From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190509152247.26164-1-yuehaibing@huawei.com> Date: Mon, 13 May 2019 18:42:11 -0400 In-Reply-To: <20190509152247.26164-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Thu, 9 May 2019 23:22:47 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9256 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=783 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905130151 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9256 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=832 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905130152 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing, > If ev->ev_code is not 0x1C, sshdr.sense_key may be used > uninitialized. Fix this by initializing variable 'sshdr' to 0. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering