From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <yanaijie@huawei.com>,
<chenxiang66@hisilicon.com>, <luojiaxing@huawei.com>
Subject: Re: [PATCH 0/6] libsas: Some minor improvements and tidy-up
Date: Mon, 15 Apr 2019 19:33:24 -0400 [thread overview]
Message-ID: <yq1v9zehmij.fsf@oracle.com> (raw)
In-Reply-To: <1555059478-36224-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Fri, 12 Apr 2019 16:57:51 +0800")
John,
> This patchset introduces some minor improvements and tidy-up, including:
> - fix PHY info in sysfs for PHY events
> - min pathway rate programming improvement
> - some other tidy-up and neatening
Applied to 5.2/scsi-queue, thanks!
One thing that always bugged me is the ambiguous "ex" prefix for many
libsas log messages. And in a way, your patch #3 makes things worse by
replacing the more descriptive "Expander" with "ex". It does make things
more consistent, though.
I'd really like to see all the libsas messages be cleaned up with a
sensible prefix and a consistent format where possible.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-04-15 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 8:57 [PATCH 0/6] libsas: Some minor improvements and tidy-up John Garry
2019-04-12 8:57 ` [PATCH 1/6] scsi: libsas: Stop hardcoding SAS address length John Garry
2019-04-12 8:57 ` [PATCH 2/6] scsi: libsas: Try to retain programmed min linkrate for SATA min pathway unmatch fixing John Garry
2019-04-12 8:57 ` [PATCH 3/6] scsi: libsas: Improve vague log in SAS rediscovery John Garry
2019-04-12 8:57 ` [PATCH 4/6] scsi: libsas: Inject revalidate event for root port event John Garry
2019-04-12 8:57 ` [PATCH 5/6] scsi: libsas: Do discovery on empty PHY to update PHY info John Garry
2019-04-12 8:57 ` [PATCH 6/6] scsi: libsas: Print expander PHY indexes in decimal John Garry
2019-04-15 23:33 ` Martin K. Petersen [this message]
2019-04-24 20:00 ` [PATCH 0/6] libsas: Some minor improvements and tidy-up John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v9zehmij.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luojiaxing@huawei.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox