From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <kashyap.desai@broadcom.com>, <sumit.saxena@broadcom.com>,
<shivasharan.srikanteshwara@broadcom.com>,
<jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linux-kernel@vger.kernel.org>, <megaraidlinux.pdl@broadcom.com>,
<linux-scsi@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] scsi: megaraid: remove set but not used variables
Date: Tue, 16 Oct 2018 18:33:11 -0400 [thread overview]
Message-ID: <yq1va61plnc.fsf@oracle.com> (raw)
In-Reply-To: <20180926110940.16024-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Wed, 26 Sep 2018 19:09:40 +0800")
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_mbox_sync_scb':
> drivers/scsi/megaraid/megaraid_mbox.c:2193:14: warning:
> variable 'ccb' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_reset_handler':
> drivers/scsi/megaraid/megaraid_mbox.c:2580:7: warning:
> variable 'recovering' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'mbox_post_sync_cmd':
> drivers/scsi/megaraid/megaraid_mbox.c:2728:12: warning:
> variable 'mbox64' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_mbox_support_random_del':
> drivers/scsi/megaraid/megaraid_mbox.c:3138:11: warning:
> variable 'mbox' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_mbox_flush_cache':
> drivers/scsi/megaraid/megaraid_mbox.c:3266:10: warning:
> variable 'mbox' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'megaraid_mbox_fire_sync_cmd':
> drivers/scsi/megaraid/megaraid_mbox.c:3302:12: warning:
> variable 'mbox64' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/megaraid/megaraid_mbox.c: In function 'gather_hbainfo':
> drivers/scsi/megaraid/megaraid_mbox.c:3797:10: warning:
> variable 'dmajor' set but not used [-Wunused-but-set-variable]
Applied by hand to 4.20/scsi-queue due to conflict with Christoph's DMA
API cleanup.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-10-16 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:09 [PATCH -next] scsi: megaraid: remove set but not used variables YueHaibing
2018-10-16 22:33 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1va61plnc.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox