From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbdJaQfY (ORCPT ); Tue, 31 Oct 2017 12:35:24 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42578 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932342AbdJaQfW (ORCPT ); Tue, 31 Oct 2017 12:35:22 -0400 To: Kees Cook Cc: "Martin K. Petersen" , Hannes Reinecke , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: aic7xxx: Convert timers to use timer_setup() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20171025100526.GA144967@beast> Date: Tue, 31 Oct 2017 12:35:12 -0400 In-Reply-To: <20171025100526.GA144967@beast> (Kees Cook's message of "Wed, 25 Oct 2017 03:05:26 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, > stat_timer only ever assigns the same function and data, so > consolidate to using timer_setup(), adjust callback, drop everything > else used to pass things around, and remove needless typedefs. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering