Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

Nathan Chancellor
2019-01-26T19:12:10Z

On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of
> variable of type 'unsigned char' to itself [-Wself-assign]
> offset = offset;
> ~~~~~~ ^
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/scsi/nsp32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 5aac3e801903..7ce6e7acf2f3 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -2441,7 +2441,6 @@ static void nsp32_set_sync_entry(nsp32_hw_data *data,
>
> period = data->synct[entry].period_num;
> ackwidth = data->synct[entry].ackwidth;
> - offset = offset;
> sample_rate = data->synct[entry].sample_rate;
>
> target->syncreg = TO_SYNCREG(period, offset);
> --
> 2.20.0
>

Ping?