From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdKUDGQ (ORCPT ); Mon, 20 Nov 2017 22:06:16 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:35008 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbdKUDGO (ORCPT ); Mon, 20 Nov 2017 22:06:14 -0500 To: Arnd Bergmann Cc: Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , Sumit Saxena , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] scsi: 3ware: fix 32-bit time calculations From: "Martin K. Petersen" Organization: Oracle Corporation References: <20171110155840.1941250-1-arnd@arndb.de> Date: Mon, 20 Nov 2017 22:06:04 -0500 In-Reply-To: <20171110155840.1941250-1-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 10 Nov 2017 16:58:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, > twl_aen_queue_event/twa_aen_queue_event, we use do_gettimeofday() > to read the lower 32 bits of the current time in seconds, to pass > them to the TW_IOCTL_GET_NEXT_EVENT ioctl or the 3ware_aen_read > sysfs file. > > This will overflow on all architectures in year 2106, there is > not much we can do about that without breaking the ABI. User > space has 90 years to learn to deal with it, so it's probably ok. > > I'm changing it to use ktime_get_real_seconds() with a comment > to document what happens when. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering