From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbdEQBJB (ORCPT ); Tue, 16 May 2017 21:09:01 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47818 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbdEQBJA (ORCPT ); Tue, 16 May 2017 21:09:00 -0400 To: Thierry Escande Cc: Bart Van Assche , "James E . J . Bottomley" , "Martin K . Petersen" , Christoph Hellwig , "Ewan D . Milne" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] sd: Ignore sync cache failures when not supported From: "Martin K. Petersen" Organization: Oracle Corporation References: <1494506064-19680-1-git-send-email-thierry.escande@collabora.com> Date: Tue, 16 May 2017 21:08:09 -0400 In-Reply-To: <1494506064-19680-1-git-send-email-thierry.escande@collabora.com> (Thierry Escande's message of "Thu, 11 May 2017 14:34:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thierry, > Some external hard drives don't support the sync command even though > the hard drive has write cache enabled. In this case, upon suspend > request, sync cache failures are ignored if the error code in the > sense header is ILLEGAL_REQUEST. There's not much we can do for these > drives, so we shouldn't fail to suspend for this error case. The drive > may stay powered if that's the setup for the port it's plugged into. Applied to 4.12/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering