From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbcBBBW5 (ORCPT ); Mon, 1 Feb 2016 20:22:57 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:37881 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbcBBBWz (ORCPT ); Mon, 1 Feb 2016 20:22:55 -0500 To: Hannes Reinecke Cc: Alexander Duyck , James Bottomley , linux-scsi@vger.kernel.org, alexander.duyck@gmail.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, shane.seymour@hpe.com, jthumshirn@suse.de Subject: Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160121063039.3803.66.stgit@localhost.localdomain> <20160121063522.3803.23150.stgit@localhost.localdomain> <56A08AA7.6090709@suse.de> Date: Mon, 01 Feb 2016 20:22:41 -0500 In-Reply-To: <56A08AA7.6090709@suse.de> (Hannes Reinecke's message of "Thu, 21 Jan 2016 08:37:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Hannes" == Hannes Reinecke writes: Hannes> And in anycase, I guess we should be using the same logic sd.c Hannes> is using. Please see the attached patch. I'm OK with this change but please send it as a proper patch submission so somebody else can review it. -- Martin K. Petersen Oracle Linux Engineering