From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Reddy\, Sreekanth" <Sreekanth.Reddy@avagotech.com>
Cc: <jejb@kernel.org>, <JBottomley@Parallels.com>,
<linux-scsi@vger.kernel.org>, <Sathya.Prakash@avagotech.com>,
<Nagalakshmi.Nandigama@avagotech.com>,
<linux-kernel@vger.kernel.org>, <hch@infradead.org>,
<martin.petersen@oracle.com>
Subject: Re: [RESEND][PATCH 08/10][SCSI]mpt2sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state
Date: Tue, 15 Jul 2014 13:58:57 -0400 [thread overview]
Message-ID: <yq1wqbetsf2.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20140625103532.GA12953@avagotech.com> (Sreekanth Reddy's message of "Wed, 25 Jun 2014 16:05:32 +0530")
>>>>> "Sreekanth" == Reddy, Sreekanth <Sreekanth.Reddy@avagotech.com> writes:
Sreekanth> The driver would send IOC facts only if HBA is in operational
Sreekanth> or ready state. If it is in fault state, a diagnostic reset
Sreekanth> would be issued. It would wait for 10 seconds to exit out of
Sreekanth> reset state. If the HBA continues to be in reset state, then
Sreekanth> the HBA wouldn't be claimed by the driver.
Your patch header describes what used to happen. What does the patched
code do?
Also, several of your patches move large functions around within the
file. That makes it really hard to figure out what the actual code
changes are. Please split changes like that in two: One patch that moves
stuff around in bulk without any functional changes and a second that
addresses the issue at hand. That makes reviewing much easier.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-07-15 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 10:35 [RESEND][PATCH 08/10][SCSI]mpt2sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state Reddy, Sreekanth
2014-07-15 17:58 ` Martin K. Petersen [this message]
[not found] ` <CAK=zhgoWvnXFdGqVevWJmLpDebb0fq9euYjxJE+EEGYqLoPrhw@mail.gmail.com>
2014-07-16 7:06 ` Christoph Hellwig
2014-07-16 17:22 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-08-23 15:04 [RESEND][PATCH 08/10] [scsi] mpt2sas: " Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wqbetsf2.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=JBottomley@Parallels.com \
--cc=Nagalakshmi.Nandigama@avagotech.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=Sreekanth.Reddy@avagotech.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox